fix(next-auth): signOut and middleware cookie error #10907
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut setting cookies Using `signOut()` in middleware cause the next error: `Error: Cookies can only be modified in a Server Action or Route Handler. Read more: https://nextjs.org/docs/app/api-reference/functions/cookies#cookiessetname-value-options` We can make a redirect with settings cookie in middleware using Next but it should be assign to the NextResponse object as ``` const response = NextResponse.redirect(url) response.cookies.set("myCookie", myJwt); return response ``` This PR allow the signOut method to return the response object without setting the cookie using the next/headers cookie method.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@jbpin is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ndom91
changed the title
|
I have the same error when using unstable_update() from a server action inside a try catch statement, do you know if this solution could be applied to that? |
|
In general, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Using
signOut()in middleware cause the NextJS error:Error: Cookies can only be modified in a Server Action or Route Handler. Read more: [https://nextjs.org/docs/app/api-reference/functions/cookies#cookiessetname-value-options](https://nextjs.org/docs/app/api-reference/functions/cookies#cookiessetname-value-options%60)We can make a redirect and settings cookie in a middleware using Next but it should be assign to the NextResponse object as
This PR allow the signOut method to return the response object without setting the cookie using the next/headers cookie method. So doing, passing
redirect: falsein the signOut options, give the user the reponsibility/ability to set the cookie in the response of the redirect directly.🧢 Checklist
🎫 Affected issues
N/A
📌 Resources