Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining Continuous Operators: make them Jax-compatible pytrees #1744

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PhilipVinc
Copy link
Member

As the Jax operator interface for discrete operator is turning out very successful and extremely useful and easy to use, I'm thinking about turning ContinuousOperators into something very similar.

This also makes it much simpler to use them in custom codes.

This should be very low effort, as they already are simple jax transformations and are much simpler than their discrete counterparts...

Should be further discussed.

cc @gpescia

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 51.34%. Comparing base (28866b9) to head (06401cb).

Files Patch % Lines
netket/operator/_potential.py 47.82% 12 Missing ⚠️
netket/operator/_sumoperators.py 60.00% 8 Missing ⚠️
netket/operator/_kinetic.py 75.00% 5 Missing ⚠️
netket/vqs/mc/mc_state/expect.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1744       +/-   ##
===========================================
- Coverage   82.75%   51.34%   -31.41%     
===========================================
  Files         300      300               
  Lines       18300    18332       +32     
  Branches     3483     3485        +2     
===========================================
- Hits        15144     9413     -5731     
- Misses       2477     8226     +5749     
- Partials      679      693       +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant