fix: trigger LspDetach on buffer delete #28795
Merged
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookayin
reviewed
May 17, 2024
| buffer = bufnr, | ||
| modeline = false, | ||
| data = { client_id = client.id }, | ||
| }) |
There was a problem hiding this comment.
Q: what happens if the autocmd handler throws an error?
There was a problem hiding this comment.
I hadn't thought of that, but are errors actually propagated through nvim_exec_autocmds?
There was a problem hiding this comment.
Tested with a simple handler that just unconditionally errors, and it doesn't seem to break anything for a normal LSP. I say normal because it was breaking things with null-ls (none-ls), but the error was coming from the client.notify call, which null-ls monkey-patches afaik. Not sure if this is something that should be accounted for.
mfussenegger
force-pushed
the
lspdetach-on-bufdelete
branch
from
65a9536
to
1fa28fd
Compare
|
Thanks. I extended a test case to cover the LspDetach event. |
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
Co-authored-by: Mathias Fussenegger <f.mathias@zignar.net> (cherry picked from commit 5ac8db1)
|
Successfully created backport PR for |
huangyingw
pushed a commit
to huangyingw/neovim
that referenced
this pull request
May 31, 2024
Co-authored-by: Mathias Fussenegger <f.mathias@zignar.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the LspDetach autocmd is triggered when the attached client quits, or if the
vim.lsp.buf_detach_clientfunction is called, but not if the buffer is deleted.I've basically just updated the
on_detachcallback to be likebuf_detach_client. Would it perhaps be better to just callbuf_detach_clientdirectly? I'm also not sure if thevim.diagnostic.resetbit is necessary.There should probably be a test for this, but I have no idea how any of that works... this PR is mostly because it was easier than writing up a bug report :) Please feel free to make/suggest any necessary changes.