fix: change deprecation presentation #28778
Merged
+122
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dundargoc
changed the title
|
The message can still contain specifics (like the name of the function, and possibly the file?) -- the important thing is that it is guaranteed to be a single line so it doesn't trigger the dreaded "press enter" prompt. In particular, the full stack trace should be punted to the health check (as you propose). |
To be clear: it can occupy |
dundargoc
force-pushed
the
fix/deprecate
branch
10 times, most recently
from
e1212d5
to
a5c19ea
Compare
dundargoc
force-pushed
the
fix/deprecate
branch
10 times, most recently
from
8617b53
to
101acb9
Compare
dundargoc
changed the title
dundargoc
requested review from
a team and
mfussenegger
and removed request for
a team
wookayin
reviewed
May 20, 2024
justinmk
reviewed
May 21, 2024
dundargoc
force-pushed
the
fix/deprecate
branch
9 times, most recently
from
7b7fb80
to
c218c8f
Compare
Deprecation with vim.deprecate is currently too noisy. Show the following warning instead: [function] is deprecated. Run ":checkhealth vim.deprecated" for more information. The important part is that the full message needs to be short enough to fit in one line in order to not trigger the "Press ENTER or type command to continue" prompt. The full information and stack trace for the deprecated functions will be shown in the new healthcheck `vim.deprecated`.
github-actions
bot
removed request for
mfussenegger,
bfredl,
clason,
seandewar,
lewis6991,
gpanders,
ii14 and
justinmk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation with vim.deprecate is currently too noisy. Show the
following warning instead:
[function] is deprecated. Run ":checkhealth vim.deprecated" for more information.
The important part is that the full message needs to be short enough to
fit in one line in order to not trigger the "Press ENTER or type command
to continue" prompt.
The full information and stack trace for the deprecated functions will
be shown in the new healthcheck
vim.deprecated.