fix(treesitter): don't open fold when adding a line below it with o/O #28709
+63
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtomjhj
changed the title
o open fold under cursor
Problem: `o`-ing on a folded line opens the fold, because the new line gets the fold level from the above line (level '='), which extends the fold to the new line. `O` has a similar problem when run on the line below a fold. Solution: Use -1 for the added line to get the lower level from the above/below line.
tomtomjhj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
o-ing on a folded line opens the fold, because the new line gets thefold level from the above line (level '='), which extends the fold to
the new line.
Ohas a similar problem when run on the line below afold.
Solution:
Use -1 for the added line to get the lower level from the above/below
line.
Originally,
-1was used for the added line, but I changed it to'='in #26506 because it looked nicer on the markdown test case (the "doesn't open folds that are not touched" test), but it turns out this is quite bad. This PR reverts that change.