Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/lint: allow the first word to be an option with -- #14171

Merged
merged 3 commits into from
May 20, 2024

Conversation

guidocella
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented May 18, 2024

Download the artifacts for this pull request:

Windows
macOS

@kasper93
Copy link
Contributor

kasper93 commented May 18, 2024

I don't think so we want this, it would look awkward, no?

@guidocella
Copy link
Contributor Author

We have several commits like this, see git log --grep=:\ -- --format=%s

ci/lint-commit-msg.py Outdated Show resolved Hide resolved
@guidocella guidocella force-pushed the lint-option branch 2 times, most recently from 1460d2a to f53aaf4 Compare May 18, 2024 21:47
ci/lint-commit-msg.py Outdated Show resolved Hide resolved
ci/lint-commit-msg.py Outdated Show resolved Hide resolved
ci/lint-commit-msg.py Outdated Show resolved Hide resolved
@guidocella guidocella force-pushed the lint-option branch 2 times, most recently from 251fa15 to 312cc4e Compare May 20, 2024 15:08
@guidocella guidocella force-pushed the lint-option branch 2 times, most recently from 8b60487 to 4a6de0c Compare May 20, 2024 16:03
ci/lint-commit-msg.py Outdated Show resolved Hide resolved
@kasper93 kasper93 merged commit 4bbaa4d into mpv-player:master May 20, 2024
18 checks passed
@guidocella guidocella deleted the lint-option branch May 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants