Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl [APK included] #58

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

youtube-dl [APK included] #58

wants to merge 7 commits into from

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Aug 3, 2017

Dev TODO:

  • integrate Python build script from here
  • develop alternative solution to deal with SDK 28 restrictions (see context)

Mini-FAQ:

  • Will this be integrated into the regular mpv-android?
    • Due to unsolved compatibility issues there are no plans at this time. The feature wouldn't make it into Google Play builds anyway.
  • Remote videos take so long to load, why? can you fix it?
    • Python and yt-dlp just aren't very fast. There is effectively nothing I can do about it.
  • My phone tells me it has blocked an insecure app from installing when I try this APK. Should I be concerned?
    • No, that's normal. You can choose to install it anyway.

APK Download -> https://kitsunemimi.pw/tmp/mpv-android-2024-05-05.apk
sha1: 32c99e7f7d5553aba5c145ae966dd91cac386c84
This APK installs as a separate app to normal mpv, there's no easy way to copy your config (sorry).

@sfan5 sfan5 force-pushed the sfan5/ytdl branch 2 times, most recently from e03a082 to 3de451e Compare September 18, 2017 10:23
@sfan5

This comment was marked as outdated.

@soredake
Copy link

soredake commented Sep 7, 2018

@sfan5 do you plan to merge this?

@sfan5

This comment was marked as outdated.

@Chubukov-Aleksey
Copy link

Maybe change brandname for youtube-dl enabled build? E.g.: "MPV - media player" (without youtube-dl) -> Google Play, "mpv-android" -> F-Droid and source only builds.

@kn-yami
Copy link

kn-yami commented Sep 7, 2018

Maybe change brandname for youtube-dl enabled build? E.g.: "MPV - media player" (without youtube-dl) -> Google Play, "mpv-android" -> F-Droid and source only builds.

Why?

@wangw469
Copy link

@sfan5 I found vlc download from Google play can play YouTube without ads (even in background mode). Maybe we can have this feature for Google play version.

@oott123
Copy link

oott123 commented Jan 13, 2019

What a exciting feature! Is there any plan to merge this, or, is there any work before merge this?

@qquq
Copy link

qquq commented Mar 13, 2019

Looks promising. Any ETA when it will be pushed to google play?

@sfan5 sfan5 force-pushed the sfan5/ytdl branch 2 times, most recently from b405e57 to 060f778 Compare June 21, 2019 18:17
@foxjaw
Copy link

foxjaw commented Feb 28, 2024

Yup. There are already a lot of release variants like arm64, x86_64, universal, debug, etc. Could be worth if this could be included in the releases naming it arm64-ytdlp
@IzzySoft Is it possible for you to include one variant from a release, even if this PR isn't merged ?

@IzzySoft
Copy link

IzzySoft commented Feb 28, 2024

Is it possible for you to include one variant from a release

I can pick exactly one APK, and that is matched by its name (using a regular expression). The unique key with F-Droid repos is <packageName>_<versionCode>, so there cannot be multiple variants with the same combination of the two – and my updater can only handle one APK per release (so I cannot pick two variants from the same tag/release).

But your app is not in my repo, so I'm not sure if this answers your question? APK size is already beyond the limit (30 MB per app) in my repo.

Edit: the per-ABI builds are within the limits, in case you thought to keep the F-Droid.org listing as-is and want me to include a specific variant not present there. Then you should think if both should share the same packageName, or if this special variant should have its own, specific packageName.

@foxjaw
Copy link

foxjaw commented Feb 28, 2024

So in this case the original packageName is is.xyz.mpv & a release variant with the appID is.ytdl.mpv should suffice right ?

I guess the dev should do some packageID changes under @sfan5's ytdl branch, apply this patch & release it. I think this should be enough.

@foxjaw
Copy link

foxjaw commented Feb 28, 2024

I believe NewPipe Extractor is faster than ytdl in terms of media scraping. Maybe some dev might kill their time to adapt the extractor into mpv-android. It's very lightweight & doesn't need python libraries either.
But would also lose the capability of playback of zillions of websites that ytdl supports.

@IzzySoft
Copy link

with the appID is.ytdl.mpv should suffice right ?

That should fit, yes. And the size of the APK should be below 30 MB, for my repo.

@foxjaw
Copy link

foxjaw commented Feb 28, 2024

Someone should run IzzyHard for apps above 30 mB.

@IzzySoft
Copy link

Someone should run IzzyHard for apps above 30 mB.

Someone could go ahead. The instructions are available: Setting up a simple binary F-Droid repo. That does not include all the additional things like my APK scans and update checker, but all that can be added later 😉

@foxjaw
Copy link

foxjaw commented Feb 29, 2024

Yup tqvm. mpv-android of a single ABI is just under 18mB I think it'll fit in your repo without any issues (unless you wanna have universal ABI variant).

@IzzySoft
Copy link

Universal is unlikely to fit, size-wise. I'd probably best take the arm64 variant I guess.

@sfan5
Copy link
Member Author

sfan5 commented Mar 9, 2024

I can change the app ID of this one by popular request, but I won't do any of the other suggestions.

@foxjaw
Copy link

foxjaw commented Mar 9, 2024

Yes changing appid to is.ytdl.mpv at least would be one step ahead to the roadmap. Also make sure it's arm64 & not universal.
@IzzySoft Is it okay for you to just pickup apk from this PR with https://github.com/mpv-android/mpv-android/tree/sfan5/ytdl as source code link ?
We will make sure to flag the app outdated in your repo when @sfan5 pushes a new version here.

@IzzySoft
Copy link

IzzySoft commented Mar 9, 2024

@foxjaw My updater cannot pickup APKs from PRs. It uses releases for that – as those mark apps ready for release. So no, I won't pickup APKs from PRs, sorry. I'll gladly set up the fork once it's ready and you let me know, however.

We will make sure to flag the app outdated in your repo

Oh? How you'll do that? 😜 Guess you meant to let me know that I do so then. But I'm still lost on what you mean there: will the app with the new packageName replace the current one?

@Bonboon229
Copy link

Any updates on a new apk?

@sfan5
Copy link
Member Author

sfan5 commented Apr 13, 2024

New build uploaded. It has a different appID now.

@Univalpha
Copy link

Play protect blocking New apk..
2024-5-5

@sfan5
Copy link
Member Author

sfan5 commented May 6, 2024

See FAQ in first post.

@Univalpha
Copy link

Univalpha commented May 6, 2024

See FAQ in first post.

But it's not giving option to install.

When I try to install it's show
Unable to install then apk automatically removed from phone..

Should I disable play protect first to install this version..

I installed previous versions without any issue don't know Why Play protect act weirdly.

Edit -- after disabled Play protect successfully installed thanks 👍.

@Univalpha
Copy link

See FAQ in first post.

Sorry for asking many questions but file picker working with play store version but yt version not showing anything how to fix this..

@sfan5
Copy link
Member Author

sfan5 commented May 6, 2024

Sorry for asking many questions but file picker working with play store version but yt version not showing anything how to fix this..

Not sure why that happens but you can go into system settings and then app permissions (for mpv+ytdl) and manually allow the ability to view all files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet