-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtube-dl [APK included] #58
base: master
Are you sure you want to change the base?
Conversation
e03a082
to
3de451e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7dc7b88
to
6bf95f0
Compare
c4a5f8f
to
f011298
Compare
4d4469d
to
04d0a51
Compare
@sfan5 do you plan to merge this? |
This comment was marked as outdated.
This comment was marked as outdated.
Maybe change brandname for youtube-dl enabled build? E.g.: "MPV - media player" (without youtube-dl) -> Google Play, "mpv-android" -> F-Droid and source only builds. |
Why? |
@sfan5 I found vlc download from Google play can play YouTube without ads (even in background mode). Maybe we can have this feature for Google play version. |
What a exciting feature! Is there any plan to merge this, or, is there any work before merge this? |
Looks promising. Any ETA when it will be pushed to google play? |
b405e57
to
060f778
Compare
Yup. There are already a lot of release variants like arm64, x86_64, universal, debug, etc. Could be worth if this could be included in the releases naming it |
I can pick exactly one APK, and that is matched by its name (using a regular expression). The unique key with F-Droid repos is But your app is not in my repo, so I'm not sure if this answers your question? APK size is already beyond the limit (30 MB per app) in my repo. Edit: the per-ABI builds are within the limits, in case you thought to keep the F-Droid.org listing as-is and want me to include a specific variant not present there. Then you should think if both should share the same packageName, or if this special variant should have its own, specific packageName. |
So in this case the original packageName is I guess the dev should do some packageID changes under @sfan5's |
I believe NewPipe Extractor is faster than ytdl in terms of media scraping. Maybe some dev might kill their time to adapt the extractor into mpv-android. It's very lightweight & doesn't need python libraries either. |
That should fit, yes. And the size of the APK should be below 30 MB, for my repo. |
|
Someone could go ahead. The instructions are available: Setting up a simple binary F-Droid repo. That does not include all the additional things like my APK scans and update checker, but all that can be added later 😉 |
Yup tqvm. mpv-android of a single ABI is just under 18mB I think it'll fit in your repo without any issues (unless you wanna have universal ABI variant). |
Universal is unlikely to fit, size-wise. I'd probably best take the arm64 variant I guess. |
I can change the app ID of this one by popular request, but I won't do any of the other suggestions. |
Yes changing appid to |
@foxjaw My updater cannot pickup APKs from PRs. It uses releases for that – as those mark apps ready for release. So no, I won't pickup APKs from PRs, sorry. I'll gladly set up the fork once it's ready and you let me know, however.
Oh? How you'll do that? 😜 Guess you meant to let me know that I do so then. But I'm still lost on what you mean there: will the app with the new packageName replace the current one? |
Any updates on a new apk? |
New build uploaded. It has a different appID now. |
(for the time being)
Play protect blocking New apk.. |
See FAQ in first post. |
But it's not giving option to install. When I try to install it's show Should I disable play protect first to install this version.. I installed previous versions without any issue don't know Why Play protect act weirdly. Edit -- after disabled Play protect successfully installed thanks 👍. |
Sorry for asking many questions but file picker working with play store version but yt version not showing anything how to fix this.. |
Not sure why that happens but you can go into system settings and then app permissions (for mpv+ytdl) and manually allow the ability to view all files. |
Dev TODO:
Mini-FAQ:
APK Download -> https://kitsunemimi.pw/tmp/mpv-android-2024-05-05.apk
sha1:
32c99e7f7d5553aba5c145ae966dd91cac386c84
This APK installs as a separate app to normal mpv, there's no easy way to copy your config (sorry).