Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: update containerd binary to v1.7.17 (static binaries and CI only) #47840

Merged
merged 2 commits into from
May 21, 2024

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented May 17, 2024

Update the containerd binary that's used in CI and static binaries

Update containerd (static binaries only) to [v1.7.17](https://github.com/containerd/containerd/releases/tag/v1.7.17)

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com

…CI only)

Update the containerd binary that's used in CI and static binaries

- full diff: containerd/containerd@v1.7.15...v1.7.17
- release notes: https://github.com/containerd/containerd/releases/tag/v1.7.17

```markdown changelog
Update containerd (static binaries only) to [v1.7.17](https://github.com/containerd/containerd/releases/tag/v1.7.17)
```

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland changed the title Dockerfile: update containerd binary to v1.7.16 (static binaries and CI only) Dockerfile: update containerd binary to v1.7.17 (static binaries and CI only) May 17, 2024
@thaJeztah
Copy link
Member

This one continues to be flaky. Is that actually related to containerd's shange to use blocksize?;

=== Failed
=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:43: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.77s)

@vvoland
Copy link
Contributor Author

vvoland commented May 21, 2024

Yeah I think it's related. That would solve the flakiness of this test, as now the behavior seems to be consistent 😅

EDIT: Oh, that change wasn't a recent one..

@thaJeztah
Copy link
Member

Yes, I also went looking, and that change in continuity already was merged a long time ago (v0.1.0 even?), so curious why it starts to fail more often.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 8470add into moby:master May 21, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants