Initial Implementation of LV2 module #983
Conversation
There was a problem hiding this comment.
The approach of copying the jackrack module and modifying it is not acceptable. That brings in a lot of baggage. jackrack code base was chosen at a time when I needed to support a rack XML file made with its GUI tool for a customer. This was a time when there were only some toy GUI tools for MLT. As a bonus it added support for JACK. I later modified it to support a single named LADSPA plugin for Kdenlive and friends. This ought to be a cleaner implementation without all of that baggage. I guess you can get there by continuing to modify, but I am not in a situation where I want to go through many PR reviews to get there. Alternatively, can the existing jackrack module be extended to support LV2?
src/modules/lv2/factory.c
Outdated
| s = calloc(1, strlen("lv2.") + strlen (desc->uri) + 1); | ||
|
|
||
| sprintf(s, "lv2.%s", desc->uri); | ||
|
|
||
| char *str_ptr = strchr(s, ':'); | ||
| while (str_ptr != NULL) | ||
| { | ||
| *str_ptr++ = '<'; | ||
| str_ptr = strchr(str_ptr, ':'); | ||
| } |
There was a problem hiding this comment.
Regarding the plugin name, since it must be altered, please drop the broken scheme and just make it like "lv2//kxstudio.sf.net/carla/plugins/audiogain_s". Then, we can just say it is the schema-less URI. Notice I did not include a period after "lv2" because the "//" is enough delimiters but still following some URI grammar. Or, since we are breaking URI grammar use "lv2.kxstudio.sf.net/carla/plugins/audiogain_s". Your choice between the two, but I would rather not hear from people trying to use "http:" either in support issues or as bug reports.
There was a problem hiding this comment.
As we said : can't be used in filter name for some reason.
Not all lv2 URIs contain http:// for example this one don't:
urn:distrho:vitalium
and < is disallowed in URI sytax so it can't conflict I there is chance there is another plugin URI with similar name but different delimiter and mlt/melt accept it so I choose it.
but still this is ugly there should be another solution.
At first I tried to extend the jackrack module and even put both LADSPA and LV2 plugins in the same plugin manager but I fail to get working code for months until I tried copying and I get here. Actually I have to think about the approach and take time to be more familiar with filter design in mlt. The problem is it was hard for me to use same structure of plugin/process/manager so I have to heavily alter it and only |
|
with this commit aba53e9 now parameters metadata is more accurate and not causing issues and be readonly
And still I don't get dropdown options (enumerations) to work. I am investigating ways to integrate this module in |
joinlaw
force-pushed
the
lv2-module
branch
2 times, most recently
from
9646013
to
189bbf4
Compare
|
By now this feature is reimplemented as part of jackrack module and the old implementation moved to |
…at lv2 feature in jackrack module
…s in filter_lv2.yml
Can be tested with melt eg:
$ melt ~/path/to/audio/file.wav -attach "lv2.http<//kxstudio.sf.net/carla/plugins/audiogain_s" 5=0.3 -consumer avformat:processed.mp3 acodec=libmp3lame
(:) in http://kxstudio.sf.net/carla/plugins/audiogain_s replaced with (<) because melt and/or mlt doesn't accept (:) in plugin name and also uri should be prefiexed with "lv2."
currently only this extensions are supported:
http://lv2plug.in/ns/ext/buf-size#boundedBlockLength
http://lv2plug.in/ns/ext/urid#map
http://lv2plug.in/ns/ext/urid#unmap
http://lv2plug.in/ns/ext/options#options
https://lv2plug.in/pages/host-compatibility.html