ldap: Add user DN attributes list config param #19758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatello
force-pushed
the
ldap-attribs
branch
9 times, most recently
from
e815d6b
to
88e1ac3
Compare
zveinn
approved these changes
May 21, 2024
taran-p
approved these changes
May 22, 2024
|
Waiting to be merged with relevant go.mod changes. |
|
Updated PR with tag for minio/pkg/v3 but still needs console update + release. |
8 tasks
harshavardhana
requested changes
May 24, 2024
donatello
force-pushed
the
ldap-attribs
branch
2 times, most recently
from
a91cd38
to
ece80eb
Compare
This change uses the updated ldap library in minio/pkg (which was bumped up to v3). New config parameter is added for LDAP configuration to specify extra user attributes to load from the LDAP server and to store it as additional claims for the user. A test is added in sts_handlers.go that shows how to access the LDAP attributes as a claim. This is in preparation to add SSH pubkey authentication to MinIO's SFTP integration.
harshavardhana
approved these changes
May 24, 2024
8 tasks
1 task
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change uses the updated ldap library in minio/pkg (which was bumped
up to v3). New config parameter is added for LDAP configuration to
specify extra user attributes to load from the LDAP server and to store
it as additional claims for the user.
A test is added in sts_handlers.go that shows how to access the LDAP
attributes as a claim.
This is in preparation to add SSH pubkey authentication to MinIO's SFTP
integration.
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)