-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ILM metrics in metrics-v3 #19539
base: master
Are you sure you want to change the base?
Add ILM metrics in metrics-v3 #19539
Conversation
8772cb3
to
5569cda
Compare
5569cda
to
511eb44
Compare
511eb44
to
d8ef595
Compare
1624665
to
b5affab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per latest discussions, the ilm metrics should be per-server (not cluster level), and should be moved from /cluster/ilm
to root level i.e. /ilm
cc @kannappanr
9aeb390
to
2f31cfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, couple of small comments in the documentation.
c6e09df
to
8273d9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for a very late review comment.
docs/metrics/v3.md
Outdated
|
||
| Name | Type | Help | Labels | | ||
|-------------------------------------------------------|-----------|----------------------------------------------------------------------------|----------| | ||
| `minio_cluster_ilm_expiry_pending_tasks` | `counter` | Number of pending ILM expiry tasks in the queue | `server` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minio_cluster_ilm_expiry_pending_tasks
is best captured as a gauge
type metric since it can go up and come down depending on the number of objects qualified for expiration at a given time vs number of workers available to expire them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/metrics/v3.md
Outdated
| Name | Type | Help | Labels | | ||
|-------------------------------------------------------|-----------|----------------------------------------------------------------------------|----------| | ||
| `minio_cluster_ilm_expiry_pending_tasks` | `counter` | Number of pending ILM expiry tasks in the queue | `server` | | ||
| `minio_cluster_ilm_transition_active_tasks` | `counter` | Number of active ILM transition tasks | `server` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above for minio_cluster_ilm_transition_active_tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/metrics/v3.md
Outdated
| `minio_cluster_ilm_expiry_pending_tasks` | `counter` | Number of pending ILM expiry tasks in the queue | `server` | | ||
| `minio_cluster_ilm_transition_active_tasks` | `counter` | Number of active ILM transition tasks | `server` | | ||
| `minio_cluster_ilm_transition_missed_immediate_tasks` | `counter` | Number of missed immediate ILM transition tasks | `server` | | ||
| `minio_cluster_ilm_transition_pending_tasks` | `counter` | Number of pending ILM transition tasks in the queue | `server` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above for minio_cluster_ilm_transition_pending_tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
a5cf067
to
fcf60c4
Compare
Co-authored-by: Shireesh Anjal <355479+anjalshireesh@users.noreply.github.com> Signed-off-by: Bala.FA <bala@minio.io>
fcf60c4
to
caa4269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Endpoint: /minio/metrics/v3/ilm
Metrics:
Motivation and Context
https://github.com/miniohq/engineering/issues/1510
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)