Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Adds a memory connector for Azure Cosmos DB for NoSQL #6148

Merged
merged 27 commits into from May 20, 2024
Merged

.Net: Adds a memory connector for Azure Cosmos DB for NoSQL #6148

merged 27 commits into from May 20, 2024

Conversation

Pilchie
Copy link
Member

@Pilchie Pilchie commented May 7, 2024

Motivation and Context

Azure Cosmos DB is adding Vector Similarity APIs to the NoSQL project, and would like Semantic Kernel users to be able to leverage them.

Description

This adds a Memory Connector implementation for Azure Cosmos DB's, including support for the new vector search functionality coming soon in Cosmos DB. It is mostly based off the existing connector for Azure Cosmos DB for Mongo DB vCore.

Contribution Checklist

@Pilchie Pilchie requested a review from a team as a code owner May 7, 2024 18:35
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels May 7, 2024
@github-actions github-actions bot changed the title Adds a memory connector for Azure Cosmos DB .Net: Adds a memory connector for Azure Cosmos DB May 7, 2024
@dmytrostruk dmytrostruk changed the title .Net: Adds a memory connector for Azure Cosmos DB .Net: Adds a memory connector for Azure Cosmos DB for NoSQL May 8, 2024
@Pilchie
Copy link
Member Author

Pilchie commented May 18, 2024 •
edited

I believe this is ready to go now @westey-m, @markwallace-microsoft, @stephentoub.

(Of course I spoke too soon. Rebased and fixed a couple of warnings now).

Pilchie and others added 12 commits May 17, 2024 20:14
@Pilchie
Formatting fixes
3fa098d
@Pilchie
Skip Azure Cosmos DB integration tests
2f5eee9
@Pilchie
Review feedback
e8baf68 
* Make helper types internal
* Ensure there is an appropriate embedding policy
* Fix doc comment copy/paste mistake
* Re-use constant in another place
@Pilchie
Make CosmosSystemTextJsonSerializer internal
1a92fab
@Pilchie @stephentoub
Apply indent fix
e580918 
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@Pilchie
Multi-target to .net8.0 and netstandard2.0
7d061de
@Pilchie
Fix stutter
eae8d20
@Pilchie
Avoid reading stream into string when deserializing
4f16261
@Pilchie
Optimize single collection lookup
0807f3a
@Pilchie
Avoid text writer and serialize directly to stream
47a347a
@Pilchie
Remove applicationName parameter.
cb27f3a 
Setting this after the `CosmosClient` can't be relied upon to work (it
won't if a connection has already been established in the current
implementation).
@Pilchie
Use published package for Cosmos DB
38fd7d6
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue May 20, 2024
Merged via the queue into microsoft:main with commit 3e19785 May 20, 2024
15 checks passed
@Pilchie Pilchie deleted the CosmosDB-NoSQL branch May 20, 2024 16:01
@Pilchie
Copy link
Member Author

Pilchie commented May 20, 2024

Thanks so much everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwallace-microsoft markwallace-microsoft markwallace-microsoft left review comments

@stephentoub stephentoub stephentoub approved these changes

@westey-m westey-m westey-m approved these changes

Assignees

@westey-m westey-m

Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pilchie @stephentoub @markwallace-microsoft @westey-m