Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route.continue should not change multipart form data body #30863

Merged
merged 2 commits into from
May 20, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented May 17, 2024

The bug was fixed in #30734. This PR adds a test and updates interception logic to not send post data when it is not modified.

Fixes #30788

This comment has been minimized.

The bug was fixed in microsoft#30734.
This PR adds a test and updates interception logic to not send post data
when it is not modified.

Fixes microsoft#30788

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body

27017 passed, 610 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit 0428964 into microsoft:main May 20, 2024
30 checks passed
@yury-s yury-s deleted the continue-form-data branch May 20, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Upgrade to Playwright 1.44 Causes Incomplete multipart/form-data Request Body
2 participants