Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking command support (BLPOP/BRPOP & BLMOVE) #356

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Blocking command support (BLPOP/BRPOP & BLMOVE) #356

wants to merge 33 commits into from

Conversation

TalZaccai
Copy link
Contributor

@TalZaccai TalZaccai commented May 2, 2024 •
edited

  • Adding support for blocking commands in Garnet (for List and SortedSet objects)
  • Implementing logic for BRPOP/BLPOP & BLMOVE commands

Still remaining to address in this PR:

  • Block processing of further commands once a blocking command has been called
  • Stop the main loop in CollectionItemBroker if there are no active observers
  • Periodically clean up "zombie" observers (observers whose resp session has disposed but are still on the key's observer queue)
  • Remove keys whose observer queues are empty
  • Add more test cases

@TalZaccai TalZaccai requested a review from badrishc May 2, 2024 22:37
@TalZaccai TalZaccai added enhancement New feature or request API labels May 2, 2024
@TalZaccai TalZaccai requested a review from badrishc June 4, 2024 22:39
@TalZaccai TalZaccai changed the title [WIP] Blocking command support Blocking command support (BLPOP/BRPOP) Jun 4, 2024
@TalZaccai TalZaccai marked this pull request as ready for review June 4, 2024 22:40
@TalZaccai TalZaccai changed the title Blocking command support (BLPOP/BRPOP) Blocking command support (BLPOP/BRPOP & BLMOVE) Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badrishc badrishc Awaiting requested review from badrishc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TalZaccai @badrishc