Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue: The web_proxy doesn't work when set proxy with uri #1780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ceasor
Copy link

@ceasor ceasor commented Nov 23, 2023

http_client_winhttp::send_request only handle the case when proxy.is_auto_discovery() return true.
image
So when we construct a web_proxy with uri, it will only set the proxy mode as user_provided_.
image
So send_request will ignore the proxy setting when we use uri to construct a web_proxy.

My modification tries to fix the problem.

@ceasor
Copy link
Author

ceasor commented Nov 23, 2023

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant