New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some UBs and memory leaks #1757

Open

dimhotepus wants to merge 3 commits into microsoft:master from The-White-Box:pvs-bug-fixes

Contributor

dimhotepus commented May 19, 2023

Do not leak clocale on _create_locale failed.
Add missed class member initializers to prevent UB on access to them.
Do not perform string -> char* -> string casts, use string directly.

Found by PVS-Studio https://pvs-studio.com/en/

dimhotepus added 3 commits

May 19, 2023 04:11


          [utilities]: Fix memory leak in case _create_locale failed

9f611ab


          [http]: Initialize missed class members

989f951


          [uri] Do not do string -> char* -> string casts

a41cd97

dimhotepus changed the title ~~Fix some UBs and memory leaks.~~ Fix some UBs and memory leaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment