Improving OpenSSL search for APPLE platform #1624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improving openssl search condition for APPLE
|
I also had this problem， hope you pr helpful |
|
can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MacOS BigSurr while compiling the repo we are not able to find
OpenSSL (required version >= 1.0.0)
On investigation, it was happening because of two cmake variables not being set properly: OPENSSL_INCLUDE_DIR, OPENSSL_LIBRARIES
when running pkg_search_module(OPENSSL openssl) to get info on openssl, we end up with
-- OPENSSL_INCLUDE_DIR =
-- OPENSSL_LIBRARIES = ssl;crypto
find_package(OpenSSL 1.0.0 REQUIRED), which is a fallback when pkg_search_module fails, is able to set the values properly.
-- OPENSSL_INCLUDE_DIR = /usr/local/opt/openssl@1.1/include
-- OPENSSL_LIBRARIES = /usr/local/opt/openssl@1.1/lib/libssl.dylib;/usr/local/opt/openssl@1.1/lib/libcrypto.dylib
So I'm making changes to strengthen the condition which makes us to go to fallback.