Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to Instrument classes #6087

Merged
merged 12 commits into from
May 21, 2024

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented May 18, 2024

This converts the remaining instruments not in #6012

  • News fragment

@jenshnielsen jenshnielsen requested a review from a team as a code owner May 18, 2024 06:57
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 86.69725% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 67.65%. Comparing base (48d51b7) to head (bf209bd).

Files Patch % Lines
...nstrument_drivers/Lakeshore/Lakeshore_model_325.py 66.66% 3 Missing ⚠️
...rc/qcodes/instrument_drivers/rigol/Rigol_DG1062.py 66.66% 3 Missing ⚠️
...rc/qcodes/instrument_drivers/rigol/Rigol_DS4000.py 62.50% 3 Missing ⚠️
...odes/instrument_drivers/stanford_research/SR86x.py 50.00% 3 Missing ⚠️
src/qcodes/instrument_drivers/yokogawa/GS200.py 62.50% 3 Missing ⚠️
...c/qcodes/instrument_drivers/Lakeshore/Model_325.py 80.00% 1 Missing ⚠️
...codes/instrument_drivers/Minicircuits/Base_SPDT.py 75.00% 1 Missing ⚠️
...ment_drivers/Minicircuits/_minicircuits_rc_sp4t.py 50.00% 1 Missing ⚠️
...ment_drivers/Minicircuits/_minicircuits_rc_spdt.py 50.00% 1 Missing ⚠️
...ent_drivers/QuantumDesign/DynaCoolPPMS/DynaCool.py 80.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6087      +/-   ##
==========================================
+ Coverage   67.62%   67.65%   +0.02%     
==========================================
  Files         351      351              
  Lines       30561    30591      +30     
==========================================
+ Hits        20668    20697      +29     
- Misses       9893     9894       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@jenshnielsen jenshnielsen added this pull request to the merge queue May 21, 2024
Merged via the queue into microsoft:main with commit 4081238 May 21, 2024
20 checks passed
@jenshnielsen jenshnielsen deleted the types_instrument_L branch May 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants