Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate convenience methods on Instrument classes #6086

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented May 17, 2024

Following the discussion in #6080 I think we should consider getting rid of these methods on the instrument classes.

All of this functionality can be done in ways that is more obvious, direct and more frequently used

E.g. parameter and functions can be looked up from the parameters and functions delegate attr dicts if you need to look them up dynamically.

  • Fix any use of this in qcodes
  • Should check agains contrib drivers and perhaps zhinst-qcodes and others
  • Newsfragment if we want to merge this

@jenshnielsen jenshnielsen requested a review from a team as a code owner May 17, 2024 14:59
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.61%. Comparing base (239e936) to head (de2e9c2).
Report is 5 commits behind head on main.

Files Patch % Lines
src/qcodes/instrument_drivers/tektronix/AWG5014.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6086      +/-   ##
==========================================
- Coverage   67.61%   67.61%   -0.01%     
==========================================
  Files         351      351              
  Lines       30549    30561      +12     
==========================================
+ Hits        20656    20663       +7     
- Misses       9893     9898       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this deprecation. The only usefulness related to this that I can recall is calling parameters/methods/functions on channel lists, but that I already implemented and work for both proper parameters and bound methods (right?)

@jenshnielsen
Copy link
Collaborator Author

I support this deprecation. The only usefulness related to this that I can recall is calling parameters/methods/functions on channel lists, but that I already implemented and work for both proper parameters and bound methods (right?)

Yes, there was a limitation where you could not call a method on more than one channel (which was an advantage of a qcodes function) but that has since been lifted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants