Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver bugfixes [Needs testing Keysight 34465 and Triton 450] #6076

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

thangleiter
Copy link
Contributor

These are three small bugfixes on different drivers.

  • The DecaDAC range did not include the highest bit
  • Our Keysight 34465 model returns a firmware version string incompatible with convert_legacy_version_to_supported_version, so it's chopped.
  • The current section parsing did not work with our Triton 450. Replaced by a regex.

It would be great if someone could verify the last two changes work on someone else's instruments.

The total range is [0, 2**16 - 1] (0-based indexing). Previously, the maximum range value could not be set (e.g, 10 V in the [0, 10]V range).
convert_legacy_version_to_supported_version does not know how to handle the long tail my device returns.
@thangleiter thangleiter requested a review from a team as a code owner May 15, 2024 14:03
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.61%. Comparing base (239e936) to head (74da04c).

Files Patch % Lines
src/qcodes/instrument_drivers/Harvard/Decadac.py 0.00% 3 Missing ⚠️
src/qcodes/instrument_drivers/oxford/triton.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6076   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files         351      351           
  Lines       30549    30549           
=======================================
  Hits        20656    20656           
  Misses       9893     9893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen
Copy link
Collaborator

@thangleiter Thanks for the contribution. I don't have access to test these but they seems sensible to me. Could you add a newsfragment as descripted in the pull request template. You will also need to run the precommit hooks to fix small formatting issues.

@jenshnielsen
Copy link
Collaborator

@thangleiter FYI you don't need to worry about merging main into the branch. We will automatically test against latest main when merging

@jenshnielsen jenshnielsen changed the title Driver bugfixes Driver bugfixes [Needs testing Keysight 34465 and Triton 450] May 17, 2024
@jenshnielsen
Copy link
Collaborator

@thangleiter I changed the title to try to ask for testing a bit more clear. I will leave it for a few days before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants