-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver bugfixes [Needs testing Keysight 34465 and Triton 450] #6076
base: main
Are you sure you want to change the base?
Conversation
The total range is [0, 2**16 - 1] (0-based indexing). Previously, the maximum range value could not be set (e.g, 10 V in the [0, 10]V range).
convert_legacy_version_to_supported_version does not know how to handle the long tail my device returns.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6076 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 351 351
Lines 30549 30549
=======================================
Hits 20656 20656
Misses 9893 9893 ☔ View full report in Codecov by Sentry. |
@thangleiter Thanks for the contribution. I don't have access to test these but they seems sensible to me. Could you add a newsfragment as descripted in the pull request template. You will also need to run the precommit hooks to fix small formatting issues. |
@thangleiter FYI you don't need to worry about merging main into the branch. We will automatically test against latest main when merging |
@thangleiter I changed the title to try to ask for testing a bit more clear. I will leave it for a few days before merging |
These are three small bugfixes on different drivers.
convert_legacy_version_to_supported_version
, so it's chopped.It would be great if someone could verify the last two changes work on someone else's instruments.