Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the System_Boundary stereotype #5243

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jonmcewen
Copy link

📑 Summary

Trivial change to correct the [ENTERPRISE] stereotype label to [SYSTEM] for C4 System_Boundary.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 0e63233
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6657b1cbdd249c0008110e37
😎 Deploy Preview https://deploy-preview-5243--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.73%. Comparing base (d6ccd93) to head (0e63233).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5243   +/-   ##
=======================================
  Coverage     5.73%   5.73%           
=======================================
  Files          278     278           
  Lines        41999   41999           
  Branches       490     490           
=======================================
  Hits          2409    2409           
  Misses       39590   39590           
Flag Coverage Δ
unit 5.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sidharthv96
Copy link
Member

@mermaid-js/atlantians can someone familiar with C4 review?

@jonmcewen
Copy link
Author

@mermaid-js/atlantians can someone familiar with C4 review?

@mermaid-js/atlantians this should be a quick-win review for someone with a minute to spare please!

Copy link
Member

@Yash-Singh1 Yash-Singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mermaid-js/atlantians can someone familiar with C4 review?

I haven't worked on the C4 Diagram, but this fixes the example case in docs to have a system boundary labelled correctly on BankBoundary2. Earlier it was labelled as enterprise boundary.

@nirname
Copy link
Contributor

nirname commented May 29, 2024

I haven't worked with C4 either, but this seems to be an obvious fix

@nirname nirname enabled auto-merge May 29, 2024 22:57
@nirname nirname disabled auto-merge May 29, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Opinion
Development

Successfully merging this pull request may close these issues.

None yet

4 participants