Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index the _geo fields when changing the setting while there is already documents in the DB #4642

Merged
merged 4 commits into from
May 21, 2024
Merged

Index the _geo fields when changing the setting while there is already documents in the DB #4642

merged 4 commits into from
May 21, 2024

Conversation

irevoire
Copy link
Member

Pull Request

Related issue

Fixes #4640
Fixes #4628

What does this PR do?

  • Add an integration test that first indexes the document and then changes the settings
  • Fix extract_geo_point by detecting if the _geo field has been faceted in this setting change and index all documents

@irevoire irevoire added bug Something isn't working as expected geo search Everything related to Geo search stuff settings diff-indexing Issues related to settings diff-indexing labels May 20, 2024
@irevoire irevoire changed the title add a test reproducing the bug Index the _geo fields when changing the setting while there is already documents in the DB May 20, 2024
@ManyTheFish ManyTheFish changed the base branch from release-v1.8.0 to release-v1.8.1 May 21, 2024 11:46
@ManyTheFish ManyTheFish marked this pull request as ready for review May 21, 2024 11:49
@ManyTheFish ManyTheFish self-requested a review May 21, 2024 11:49
@irevoire irevoire added this to the v1.8.1 milestone May 21, 2024
ManyTheFish
ManyTheFish approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented May 21, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 9066a44 into release-v1.8.1 May 21, 2024
10 checks passed
@meili-bors meili-bors bot deleted the fix-bad-geo branch May 21, 2024 14:12
@ManyTheFish ManyTheFish mentioned this pull request May 22, 2024
Closed
@curquiza curquiza mentioned this pull request May 22, 2024
Closed
@meili-bot meili-bot added the v1.8.1 PRs/issues solved in v1.8.1 label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected geo search Everything related to Geo search stuff settings diff-indexing Issues related to settings diff-indexing v1.8.1 PRs/issues solved in v1.8.1
Projects
None yet
Milestone
v1.8.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irevoire @ManyTheFish @meili-bot