Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 46 compatibility #993

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ajwild
Copy link

@ajwild ajwild commented May 18, 2024

Issue: #991

Documentation used for the upgrade:
https://gjs.guide/extensions/upgrading/gnome-shell-46.html
https://mutter.gnome.org/cogl/struct.Color.html

The Shell.BlurEffect should change from using sigma to radius, but this requires an update to the TypeScript definitions and I haven't looked into that yet.

There are a couple of references to Clutter.Container which will probably need replacing.

There are some further details in the GJS upgrade guide regarding the following which may be relevant, but I haven't had time to look into it yet:

  • DateMenu.MessagesIndicator
  • MessageTray
  • PopupMenu

This is my first look at a Gnome extension's source code, so if I've done anything wrong or need to do any additional steps then just let me know. At the moment this PR gets the extension running again for me. I have not tested much of the functionality yet, and I do not know if it is backwards compatible with v45.

To give this a test you can follow the manual installation notes and switch to this branch.

@sytabaresa
Copy link

sytabaresa commented May 18, 2024

I'm testing right now, looks perfect in Manjaro running Gnome 46

@piotron
Copy link

piotron commented May 24, 2024

Gnome 46 is not working with this release(at least for me), but after upgrading to Gnome46 I was able to run it.

@thenoid
Copy link

thenoid commented May 25, 2024

Thanks for the patch <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants