Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed StampBrush to do rectangle-erase on right-click #3821

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bjorn
Copy link
Member

@bjorn bjorn commented Sep 19, 2023

Feature requested by elvisish, but can't be merged like this. Instead, the mouse interaction in general would need to be made more configurable.

This change currently leaves no way to capture a stamp from the map when the Stamp Brush is selected.

Feature requested by elvisish, but can't be merged like this. Instead,
the mouse interaction in general would need to be made more
configurable.

This change currently leaves no way to capture a stamp from the map.
@eishiya
Copy link
Contributor

eishiya commented Sep 19, 2023

I'm curious why this behaviour couldn't be added as e.g. Alt + right click, without a need for additional user configuration? When using right click, none of the modifier keys seem to do anything except break drag behaviour, so they seem free to use.

(I find the right-click sampling behaviour very useful, so of course I hope to see it stay xP)

@bjorn
Copy link
Member Author

bjorn commented Sep 19, 2023

I'm curious why this behaviour couldn't be added as e.g. Alt + right click, without a need for additional user configuration?

Hmm, you're right, Alt+Right-click is still free for all the relevant tools. It's worth considering.

@elvisish
Copy link

elvisish commented Sep 19, 2023

I'm curious why this behaviour couldn't be added as e.g. Alt + right click, without a need for additional user configuration?

Hmm, you're right, Alt+Right-click is still free for all the relevant tools. It's worth considering.

Because my tilemapping muscle-memory instinct is to just right-click, I'd never be able to convert to having to remember to press alt as well (and if it were a configurable option, I'd also never choose alt+)

@eishiya
Copy link
Contributor

eishiya commented Sep 19, 2023

I'm certainly not against more options xP And if there's an option, maybe the other behaviour can be available with alt. That way, those of us with right-click sample muscle memory from using Tiled can also be happy, and access the new feature easily.

@bjorn
Copy link
Member Author

bjorn commented Sep 26, 2023

@elvisish I've fixed the clearing of the stamp on right-click erase. New builds will soon be available at https://github.com/mapeditor/tiled/actions/runs/6309399827?pr=3821.

@elvisish
Copy link

@elvisish I've fixed the clearing of the stamp on right-click erase. New builds will soon be available at https://github.com/mapeditor/tiled/actions/runs/6309399827?pr=3821.

Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants