Make Terrain Brush fill full tiles mode toggle-able

[fjnlpy]

Hi, I have tried to address #3082. I hope it is useful.

A few things I wasn't sure about:

• I don't really understand the translations so I didn't add any for the new text I added.
• I didn't make an icon for the new toolbar tool I added; I just re-used an icon fromsomething else. But it's not really appropriate, so I need some guidance about which icon to pick.

[bjorn]

@fjnlpy This is great, thanks for working on this!

Indeed we'll need a proper icon for this. I guess some schematic, either with a full tile highlighted or we could invert the logic and have an icon that indicates a smaller change will be made.

No need to worry about the translations, I'll update those when we reach "string freeze", usually 1-2 weeks before the release.

I'm not sure it makes sense to set L as a shortcut for this toggle. Mostly because there is already Ctrl as temporary toggle, we could just leave it empty. Users who use the toggle a lot can set the shortcut themselves.

[fjnlpy]

@bjorn Thanks for responding. I removed the shortcut key and setting one from the preferences menu seems to be working ok. I'm no good at visuals and all the other icons look very nice so I wouldn't want to risk making an icon that isn't very good -- is there someone else who can make a better icon?

[eishiya]

Last month, Bjorn asked about making an icon for this on the Tiled Discord, but it doesn't look like he ever shared the result with you:

This is an SVG, so it would go into the /scalable/ directory. It may benefit from additional minifying/massaging, I don't know enough about SVG to know xP

[fjnlpy]

Hi, sorry for my delay in getting back to this, I will add the SVG and resolve conflicts soon :)

[fjnlpy]

I've added the icon, seems to be working locally for me. I initially had to add to tiled.qrc, but after merging master I see that this file no longer exists and the icon now seems to display without it. I'm not sure what the story is there but hopefully somebody who knows about Qt can keep me right ;)

[bjorn]

I've added the icon, seems to be working locally for me.

Thanks, I'll check it out!

I initially had to add to tiled.qrc, but after merging master I see that this file no longer exists and the icon now seems to display without it. I'm not sure what the story is there but hopefully somebody who knows about Qt can keep me right ;)

Yes, the creation of a resource file is taken care of by the build system since 1c1e33c, so adding the file to the src/tiled/resources folder suffices. :-)