[WIP] Fixed file reading test #2758
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
Hmm, so the test as running on Travis CI apparently broke with this change. How are you running the tests? I agree it would be nice to adjust the tests to not be sensitive to the working directory. However, I'm not sure if putting the test files in a resource file is the best way. Alternatively, we can add install rules to the Qbs project to copy these files alongside the binary, so that the test can find them relative to the binary. |
bjorn
force-pushed
the
master
branch
3 times, most recently
from
384d5ac
to
2e9a0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.