Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Mismatch dialog: Ask in the main text #2211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

encukou
Copy link
Contributor

@encukou encukou commented Oct 26, 2019

The MessageBox shows Yes/No buttons, but the question it is asking is hidden in the fine print.
I believe it would make more sense to ask questions first, and explain later.

The MessageBox shows Yes/No buttons, but the question it is asking is hidden in [the fine print](https://doc.qt.io/qt-5/qmessagebox.html#informativeText-prop).
I believe it would make more sense to ask questions first, and explain later.
@encukou
Copy link
Contributor Author

encukou commented Oct 26, 2019

Looking further, I see this happens on other dialogs as well. Do you think it's an issue?

@bjorn
Copy link
Member

bjorn commented Oct 28, 2019

Looking further, I see this happens on other dialogs as well. Do you think it's an issue?

I guess it could be an issue. I think your suggestion definitely make sense, but it depends a little on what other applications do to see what the user could really expect. I noticed the example in the QMessageBox documentation also asks the question in the informative text:

image

I do think this only really matters on macOS, I'm not sure if the message box has different formatting of the text on other platforms. I also think for Tiled 1.3 it's more important to keep the string freeze now, so I'd merge this after branching.

Feel free to extend this pull request with fixes to the other dialogs you've noticed this on.

@encukou
Copy link
Contributor Author

encukou commented Oct 29, 2019

Ah. If this is usual on Macs, it's probably not worth fixing, though it still seems weird to me. But, I certainly won't be able to prioritize working on this :(
And changing just one dialog is probably worse than not chaging anything
Please re-open if you think it's worth fixing.

@encukou encukou closed this Oct 29, 2019
@bjorn
Copy link
Member

bjorn commented Oct 29, 2019

I don't know what's usual on macOS. The QMessageBox example may not be ideal either. In the case of having unsaved changes, the usual popup seems rather more helpful:

Screen Shot 2019-10-29 at 11 56 00

Though it is true that the question is in the title, like you are suggesting.

And changing just one dialog is probably worse than not chaging anything
Please re-open if you think it's worth fixing.

Yeah, I'll reopen since I think it's worth improving this, but I'll check the other cases of "informative text" before merging.

@bjorn bjorn reopened this Oct 29, 2019
@bjorn bjorn force-pushed the master branch 3 times, most recently from 384d5ac to 2e9a0fb Compare June 25, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants