handle empty answers as EAI_ADDRFAMILY #1324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And only for hosts file, interesting.
Yes, let's fix the evdns itself. |
|
Ok, I moved the fix to evens |
|
OK. Can you please also add a unit test for this, that will show that from host entry and from real NS has the same error in this case. |
azat
reviewed
Aug 15, 2022
| /* Note that we return an empty answer if we found entries for | ||
| * this hostname but none were of the right address type. */ | ||
| if (!ai) { | ||
| return EVUTIL_EAI_ADDRFAMILY; |
There was a problem hiding this comment.
But this error does not propagated to the caller, it simply means that "OK, let's ignore entries in the /etc/hosts if they do not match"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dns resolution retrieves answers but not of the requested address family, it passes NULL as the answer. Then
bufferevent_connect_getaddrinfo_cbcrashes. This is documented here:libevent/evdns.c
Line 5567 in 99fd68a
To address this, this patch returns the error
EAI_ADDRFAMILYinstead.(I'm not particularly fond of evdns returning empty answers; it's probable that the
EAI_ADDRFAMILYresponse should be moved into evdns itself)