[11.x] Unnecessary closure wrapping in DatabaseBatchRepository::transaction
#51513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GromNaN
changed the title
DatabaseBatchRepository::transactionDatabaseBatchRepository::transaction
GromNaN
changed the title
DatabaseBatchRepository::transactionDatabaseBatchRepository::transaction
crynobone
reviewed
May 20, 2024
| @@ -309,7 +309,7 @@ public function pruneCancelled(DateTimeInterface $before) | |||
| */ | |||
| public function transaction(Closure $callback) | |||
| { | |||
| return $this->connection->transaction(fn () => $callback()); | |||
| return $this->connection->transaction($callback); | |||
There was a problem hiding this comment.
There's a slight difference between the two.
Before
/**
* @param \Closure():(mixed) $callback
*/After
/**
* @param \Closure(\Illuminate\Database\Connection):(mixed) $callback
*/
|
I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework. Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$callbackis already a closure. No need to wrap it.