Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update yfinance dependency to version 0.2.40 #4517

Merged
merged 3 commits into from
May 20, 2024

Conversation

BenjaminX
Copy link
Contributor

Description

ERROR:root:Failed to load module core.tools.provider.builtin.yahoo.yahoo from /app/api/core/tools/provider/builtin/yahoo/yahoo.py: f-string: unmatched '[' (history.py, line 1207)
Traceback (most recent call last):
File "/app/api/core/utils/module_import_helper.py", line 29, in import_module_from_source
spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/app/api/core/tools/provider/builtin/yahoo/yahoo.py", line 2, in
from core.tools.provider.builtin.yahoo.tools.ticker import YahooFinanceSearchTickerTool
File "/app/api/core/tools/provider/builtin/yahoo/tools/ticker.py", line 4, in
from yfinance import Ticker
File "/usr/local/lib/python3.10/site-packages/yfinance/init.py", line 23, in
from .ticker import Ticker
File "/usr/local/lib/python3.10/site-packages/yfinance/ticker.py", line 28, in
from .base import TickerBase
File "/usr/local/lib/python3.10/site-packages/yfinance/base.py", line 40, in
from .scrapers.history import PriceHistory
File "/usr/local/lib/python3.10/site-packages/yfinance/scrapers/history.py", line 1207
logger.debug(f'price-repair-split: Splits: {str(df['Stock Splits'][split_f].to_dict())}')
^^^^^
SyntaxError: f-string: unmatched '['
ERROR:core.tools.tool_manager:load builtin provider yahoo error: f-string: unmatched '[' (history.py, line 1207)

ranaroussi/yfinance#1942

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file 🐞 bug Something isn't working labels May 20, 2024
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2024
@Yeuoly Yeuoly merged commit 40bc936 into langgenius:main May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants