Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply and fix flake8-bugbear lint rules #4496

Merged
merged 3 commits into from
May 20, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented May 18, 2024

Description

  • apply flake-bugbear rules to prevent and reduce likely bugs and usages
  • fixed the violations in the following list:
    • B033 duplicate value in set values in Python3TemplateTransformer
    • B024 marked abstract base class but no abstract methods in the class Callback
    • B018 touching the existed fields but never assigned or used in ToolManager and ToolNode

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@bowenliang123 bowenliang123 marked this pull request as ready for review May 18, 2024 14:07
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐍 python Pull requests that update Python code labels May 18, 2024
@bowenliang123
Copy link
Contributor Author

bowenliang123 commented May 18, 2024

cc @takatost @crazywoola

Yeuoly
Yeuoly previously approved these changes May 20, 2024
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2024
@Yeuoly
Copy link
Collaborator

Yeuoly commented May 20, 2024

hello, there is a conflict need to be solved.

@bowenliang123
Copy link
Contributor Author

The conflict has been resolved.

Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yeuoly Yeuoly merged commit e8e213a into langgenius:main May 20, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the ruff-brules branch May 20, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer 🐍 python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants