-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bedrock cohere fix max length 2048 #4253
Open
kerlion
wants to merge
8
commits into
langgenius:main
Choose a base branch
from
kerlion:bedrock-coher-fix-max-length-2048
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bedrock cohere fix max length 2048 #4253
kerlion
wants to merge
8
commits into
langgenius:main
from
kerlion:bedrock-coher-fix-max-length-2048
+38
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-embedding-max-length
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
🐞 bug
Something isn't working
💪 enhancement
New feature or request
labels
May 10, 2024
crazywoola
changed the title
Bedrock coher fix max length 2048
Bedrock cohere fix max length 2048
May 14, 2024
guchenhe
requested changes
May 20, 2024
@@ -28,7 +29,7 @@ | |||
logger = logging.getLogger(__name__) | |||
|
|||
class BedrockTextEmbeddingModel(TextEmbeddingModel): | |||
|
|||
_enc = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please define this in the get_num_tokens
where its needed, instead of the class level
@kerlion Please resolve the conversation above, we will merge it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 bug
Something isn't working
💪 enhancement
New feature or request
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It includes 2 changes:
Fixes #3942
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Test with text file with consecutive punctuation marks or long English words. It will failed with expected maxLength: 2048 before. Now it is fixed by counting the tokens as chars.
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes