-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add coverage reporting for e2e tests #1726
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: nakof <12702673+nak0f@users.noreply.github.com>
This works in my local but didn't work in Github CI. Most likely, kind host volume mounts don't work in here. I will try to solve this with something else. |
…volume mounts. Signed-off-by: nakof <12702673+nak0f@users.noreply.github.com>
Signed-off-by: nakof <12702673+nak0f@users.noreply.github.com>
Signed-off-by: nakof <12702673+nak0f@users.noreply.github.com>
Signed-off-by: nakof <12702673+nak0f@users.noreply.github.com>
Signed-off-by: nakof <12702673+nak0f@users.noreply.github.com>
Signed-off-by: nakof <12702673+nak0f@users.noreply.github.com>
Signed-off-by: nakof <12702673+nak0f@users.noreply.github.com>
Below you can see output from the fist successful run:
|
@nak0f this looks good, do you think this is now ready for review? |
I was thinking of merging these with unit test coverage. Maybe adding a CI step with a coverage check. Is it better to keep this separate and leave these for future? |
whatever works for you, no hurries |
Signed-off-by: Nihat Ciddi <12702673+nak0f@users.noreply.github.com>
fixes #1533