-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intial translation of the figures for the chapters of graph, searching, and sorting #1338
Conversation
…ching, and sorting
Please review the translation based on the following aspects:
In addition to content, please pay attention to the format:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good to me.
just some bolds text again in EN ver
en/docs/chapter_graph/graph_operations.assets/adjacency_list_step2_add_edge.png
Show resolved
Hide resolved
en/docs/chapter_sorting/counting_sort.assets/counting_sort_step7.png
Outdated
Show resolved
Hide resolved
en/docs/chapter_sorting/selection_sort.assets/selection_sort_step1.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (no typos)
My only input is in bubble_sort_overview.png and selection_sort_step11.png we say,
"remaining one element"
I understand we're saying, the element that has a value of 1, correct? It might be a little confusing. Maybe use quotation marks around one (remaining "one" element) but I think that looks a little silly. Maybe format it so it sticks out more? I'd be curious what other reviewers think of this.
en/docs/chapter_sorting/summary.assets/sorting_algorithms_comparison.png
Outdated
Show resolved
Hide resolved
en/docs/chapter_searching/replace_linear_by_hashing.assets/two_sum_brute_force.png
Show resolved
Hide resolved
en/docs/chapter_searching/binary_search_insertion.assets/binary_search_insertion_naive.png
Show resolved
Hide resolved
Thanks for your thorough review! @pengchzn, @RafaelCaso, @K3v123, most of the comments have been addressed. A few comments remain unresolved for further discussion. Please let me know if there's anything else that needs fixing. |
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: