Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(access_token): handle network delays with expiry of access token #4617

Merged
merged 5 commits into from May 16, 2024
Merged

refactor(access_token): handle network delays with expiry of access token #4617

merged 5 commits into from May 16, 2024

Conversation

Narayanbhat166
Copy link
Member

@Narayanbhat166 Narayanbhat166 commented May 9, 2024 •
edited

Type of Change

  • Refactoring

Description

There might be some delay in network due to which the access token which was not expired locally, might have expired when it reaches the connector. This PR reduces the expiry of access token in order to account for such delays

Motivation and Context

How did you test it?

  • Create a payment with any connector which supports access token and then check the ttl in redis.
Screenshot 2024-05-10 at 12 24 52 AM
  • The below log can also be checked
Screenshot 2024-05-10 at 12 25 58 AM

IMPACT

  • airwallex
  • globalpay
  • paypal
  • payu
  • trustpay - bank redirect
  • iatapay
  • volt

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Narayanbhat166 Narayanbhat166 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels May 9, 2024
@Narayanbhat166 Narayanbhat166 added this to the May 2024 Release milestone May 9, 2024
@Narayanbhat166 Narayanbhat166 self-assigned this May 9, 2024
@Narayanbhat166 Narayanbhat166 requested review from a team as code owners May 9, 2024 18:56
@Narayanbhat166 Narayanbhat166 linked an issue May 9, 2024 that may be closed by this pull request
[REFACTOR]: handle network delays with expiry of access token #4463
Closed
sahkal
sahkal previously approved these changes May 13, 2024
View reviewed changes
hrithikesh026
hrithikesh026 previously approved these changes May 14, 2024
View reviewed changes
@Narayanbhat166 Narayanbhat166 dismissed stale reviews from hrithikesh026 and sahkal via 39db3d8 May 15, 2024 06:35
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 0d45f85 May 16, 2024
13 checks passed
@Gnanasundari24 Gnanasundari24 deleted the 4463-refactor-handle-network-delays-with-expiry-of-access-token branch May 16, 2024 15:04
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 19, 2024
kashif-m pushed a commit that referenced this pull request May 20, 2024
@Narayanbhat166 @kashif-m
refactor(access_token): handle network delays with expiry of access t…
7b81af6 
…oken (#4617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahkal sahkal sahkal approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@hrithikesh026 hrithikesh026 hrithikesh026 approved these changes

Assignees

@Narayanbhat166 Narayanbhat166

Labels
C-refactor Category: Refactor
Projects
None yet
Milestone
May 2024 Release
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: handle network delays with expiry of access token
6 participants
@Narayanbhat166 @sahkal @sai-harsha-vardhan @hrithikesh026 @SanchithHegde @Gnanasundari24