Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): generate connector template code for gpayments authenticaition connector #4584

Merged
merged 8 commits into from May 13, 2024

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented May 8, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Generated connector template code for gpayments authenticaition connector.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Cannot be tested since implementation is pending.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 8, 2024
@hrithikesh026 hrithikesh026 added this to the May 2024 Release milestone May 8, 2024
@hrithikesh026 hrithikesh026 self-assigned this May 8, 2024
@hrithikesh026 hrithikesh026 requested review from a team as code owners May 8, 2024 10:04
Copy link
Contributor

@SamraatBansal SamraatBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add appropriate labels like config and env changes

@@ -95,6 +95,7 @@ pub enum Connector {
Globalpay,
Globepay,
Gocardless,
Gpayments,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please comment this out as this is template code.

Follow any past template code PR and comment out at all the necessary places

@hrithikesh026 hrithikesh026 added the M-configuration-changes Metadata: This PR involves configuration changes label May 9, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 2a302eb May 13, 2024
9 of 12 checks passed
@likhinbopanna likhinbopanna deleted the generate-template-code-for-gpayments branch May 13, 2024 09:35
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants