ci(cypress): setup granular functions some minor cleanups for reusability #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
pixincreate
changed the title
it is better for reviewers to review based on commit
This reverts commit 7c0c310.
…efactor * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.05.10.0 fix(router): [NETCETERA] skip sending browser_information in authentication request for app device_channel (#4613) fix(users): Fix bugs caused by the new token only flows (#4607) ci(cypress): Fix card expiry for savecard flows (#4585) refactor(billing): store `payment_method_data_billing` for recurring payments (#4513) feat(users): new routes to accept invite and list merchants (#4591) fix(connector): [BAMBORA] Audit Fixes for Bambora (#4604) fix(connector): [iatapay]handle empty error response in case of 401 (#4291) feat(connector): [Payone] add connector template code (#4469) feat(users): Create API to Verify TOTP (#4597) chore(version): 2024.05.09.0 chore(postman): update Postman collection files fix(core): drop three_dsserver_trans_id from authentication table (#4587) refactor(db): Add TenantId field to the KafkaStore struct (#4512) feat(users): Create `user_key_store` table and `begin_totp` API (#4577) Fix(connector): [BOA/CYBS] make rsync status optional (#4570) fix(users): Correct the condition for `verify_email` flow in decision manger (#4580)
pixincreate
force-pushed
the
assertion-refactor
branch
4 times, most recently
from
9011baf
to
e1007c0
Compare
pixincreate
force-pushed
the
assertion-refactor
branch
from
e1007c0
to
a338a2e
Compare
|
Closing in favor of #4624 |
pixincreate
removed
the
S-waiting-on-review
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
First PR refactoring assertions.
prettierAdditional Changes
Motivation and Context
We need to handle assertions and responses.
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy