chore: email templates updated #4562
Open
+1,358
−1,527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitanjli525
added
the
S-waiting-on-author
gitanjli525
added
S-waiting-on-review
gitanjli525
requested review from
Riddhiagrawal001,
PritishBudhiraja,
racnan and
JeevaRamu0104
| @@ -76,7 +76,7 @@ pub mod html { | |||
| EmailBody::MagicLink { link, user_name } => { | |||
| format!( | |||
| include_str!("assets/magic_link.html"), | |||
| user_name = user_name, | |||
| username = user_name, | |||
There was a problem hiding this comment.
Why do we need this change ?
There was a problem hiding this comment.
To maintain the consistency, as in other emails, if you see, we use username for html files and user_name is what we are assigning to username. No other reason. Hence utilised "username" in the Magiclink.html file where it was required rather than user_name.
|
I don't think so head tag is required just check once it was previously working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy