Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(customers): redact default payment method field in customers table for the customer id that is deleted #4559

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(customers): redact default payment method field in customers table for the customer id that is deleted #4559

wants to merge 3 commits into from

Conversation

Aprabhat19
Copy link
Contributor

@Aprabhat19 Aprabhat19 commented May 6, 2024 •
edited

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

redact default payment method field in customers table for the customer id that is deleted

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • Create a MA and an MCA
  • Create a customer
  • Make a payment for that customer
  • Delete the customer. The default_payment_methods would be redacted
Screenshot 2024-05-06 at 3 40 13 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Aprabhat19 Aprabhat19 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-customers Area: Customer Flow/API's labels May 6, 2024
@Aprabhat19 Aprabhat19 self-assigned this May 6, 2024
@Aprabhat19 Aprabhat19 requested review from a team as code owners May 6, 2024 10:19
@Aprabhat19 Aprabhat19 requested a review from vspecky May 6, 2024 10:20
@Aprabhat19 Aprabhat19 linked an issue May 6, 2024 that may be closed by this pull request
[REFACTOR] redact default payment method field in customers table for the customer id deleted #4560
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky Awaiting requested review from vspecky

At least 2 approving reviews are required to merge this pull request.

Assignees

@Aprabhat19 Aprabhat19

Labels
A-core Area: Core flows A-customers Area: Customer Flow/API's S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] redact default payment method field in customers table for the customer id deleted
1 participant
@Aprabhat19