refactor: [Mollie] Remove Default Case Handling #4549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkurilla
changed the title
2 tasks
SanchithHegde
added
A-connector-integration
swangi-kumari
approved these changes
May 7, 2024
Sakilmostak
approved these changes
May 8, 2024
SanchithHegde
approved these changes
May 8, 2024
|
@davidkurilla Could you please address the merge conflicts? |
davidkurilla
force-pushed
the
refactor-mollie-match
branch
from
d1ecf7b
to
348cd74
Compare
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactor mollie connector default match cases. Default match arm now accounts for all enum variants in its case rather than default _ case. This PR closes Issue #4055
Additional Changes
Motivation and Context
This change refactors the default case handling in the mollie connector of the
routercrate. This change encourages developers to cover all enum variants rather than rely on default _ case.How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy