Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [multisafepay] add Ideal and Giropay payment methods #4541

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sid-rh
Copy link

@sid-rh sid-rh commented May 3, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added Ideal and Giropay payment methods for Multisafepay connector.
(see: #4143)

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes the issue #4539

How did you test it?

Used "Payments - Create" request in the Postman collection to test the API's

Giropay

Giropay only supports redirect payment type. Hence, the bank name need not be provided.
GiropayPaymentPostman
A redirection link will be found in the response which redirects to the Multisafepay test platform, where the status of the payment can be seen
GiropayPaymentPage

Ideal

Ideal supports both direct and redirect payment types.

Ideal - Direct

For proceesing a payment through direct type, bank name supported by ideal must be provided.
IdealDirectPostman
A redirection link will be found in the response which redirects to the Multisafepay test platform, where the status of the payment can be seen along with the bank name and it's logo.
IdealDirectPayment

Ideal - Redirect

For redirect type, the bank name should not be provided.
IdealRedirectPostman
The redirect url redirects to the Multisafepay test platform where a bank can be chosen.
IdealRedirctPayment
Upon choosing the bank name, it redirects to the Multisafepay test platform page with the selected bank name and payment status.
IdealRedirectPaymentComplete

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sid-rh sid-rh requested a review from a team as a code owner May 3, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant