New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connector_token): Move config redis #4540
Conversation
); | ||
|
||
redis | ||
.serialize_and_set_key_with_expiry(key.as_str(), &encoded_data.peek(), i64::from(900)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not use hardcoded 900 value instead use const something like TOKEN_TTL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
id: key, | ||
}, | ||
) | ||
.attach_printable("Failed to get redis Value") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also specify which data we failed to retrieve from redis, just for better tracking since MerchantConnectorAccountNotFound
does not specify that it is a value from external system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the result from this function logged or returned somewhere?
Also, Please put testing screenshots from stripe compatibility layer to ensure validation. |
crates/router/src/consts.rs
Outdated
@@ -113,3 +113,5 @@ pub const POLL_ID_TTL: i64 = 900; | |||
// Default Poll Config | |||
pub const DEFAULT_POLL_DELAY_IN_SECS: i8 = 2; | |||
pub const DEFAULT_POLL_FREQUENCY: i8 = 5; | |||
|
|||
pub const CONNECTOR_TOKEN_TTL: i64 = 900; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rename it to connector creds token
CI checks are failing |
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Need to test stripe compatability,Tunnel using any creds and verify in the db,config is not storing.
tested using /payment_intents flow with passing different creds
test screenshots:
Checklist
cargo +nightly fmt --all
cargo clippy