feat(analytics): org level analytics #4530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsampras
reviewed
May 3, 2024
Comment on lines
45
to
52
| let mut matching_values = vec![]; | ||
|
|
||
| for m in org_merchant_ids { | ||
| let t = m.clone(); | ||
| if payload.contains(&t) { | ||
| matching_values.push(t); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| let mut matching_values = vec![]; | |
| for m in org_merchant_ids { | |
| let t = m.clone(); | |
| if payload.contains(&t) { | |
| matching_values.push(t); | |
| } | |
| } | |
| let matching_values = payload.iter().filter(|i| org_merchant_ids.contains(i)).cloned().collect(); |
Comment on lines
+390
to
+401
| let merchant_id: Option<String> = row.try_get("merchant_id").or_else(|e| match e { | ||
| ColumnNotFound(_) => Ok(Default::default()), | ||
| e => Err(e), | ||
| })?; | ||
| Ok(Self { | ||
| currency, | ||
| status, | ||
| connector, | ||
| authentication_type, | ||
| payment_method, | ||
| payment_method_type, | ||
| merchant_id, |
There was a problem hiding this comment.
Add this deserialization handler for PaymentMetricRow & PaymentDistributionRow as well
| .map(|org| org.merchant_id.clone()) | ||
| .collect(), | ||
| ), | ||
| _ => None, |
There was a problem hiding this comment.
Suggested change
| _ => None, | |
| _ => vec![&merchant.merchant_id.clone()], |
if the user doesn't have org admin access return only a single merchant id that he is belongs to.
There was a problem hiding this comment.
it need to be none or in the every iteration it will try to push the merchant_id when the permission is not matching
…nto org-level-analytics
…nto org-level-analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Have an organisation level analytics view:
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy