make fzf work in standard Git Bash Term #3806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script provided by @knutze Addresses junegunn#2798
|
The approach looks quite similar to what we've been doing in fzf-tmux, and the script was recently rewritten in native Go code. I'll see if we can do the same for this. If that's possible,
|
junegunn
added a commit
that referenced
this pull request
May 20, 2024
Close #3806 Known limitation: * --height cannot be used
|
Can you test 573df52? It seems to work for me fine. Because it's using named pipes, it doesn't block even when the source command takes a while to complete. ./fzf
ls | ./fzf
(sleep 5; ls) | ./fzfAttaching the binary built from the source. |
|
I can confirm that this release works fine in Git Bash Term under Windows 10 without the bash script work around. |
|
Cool, I'll close this then and include the patch in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script provided by @knutze
Addresses #2798