Add parameter "enable_button_after" to all "-button-response" plugins #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a408852 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jodeleeuw
requested changes
May 17, 2024
There was a problem hiding this comment.
Thanks @thtTNT ! I have a few ideas here about the default value.
The other thing I'm wondering is whether we need to adjust the simulate method so that response times that are less than the enable_button_after parameter cannot be generated.
|
Dear @jodeleeuw, |
jodeleeuw
approved these changes
May 20, 2024
|
Thanks @thtTNT ! This looks great. |
Merged
bjoluc
reviewed
Jun 7, 2024
bjoluc
pushed a commit
that referenced
this pull request
Jun 7, 2024
Add parameter "enable_button_after" to all "-button-response" plugins (rebased-with-history from commit 87d2a8e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3289