Change "try" to "attempt" english translation #11578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
May 12, 2024
Bond-009
approved these changes
May 12, 2024
|
Can you retarget this to the release-10.9.z branch? |
Yes I will do that right away. |
This changes "Failed login try from {0}" to "Failed login attempt from {0}"
which is a more usual way of using such sentence.
TimGels
force-pushed
the
update-english-translation-login-attempt
branch
from
3eb425b
to
b757297
Compare
nielsvanvelzen
approved these changes
May 12, 2024
scampower3
added a commit
to scampower3/jellyfin
that referenced
this pull request
May 13, 2024
* Fix migration with special Rating (jellyfin#11541) * Add metrics collector to disposable parts (jellyfin#11539) * Fix absolute path checking on windows (jellyfin#11570) * Default to processor count concurrent scan instead of 2 * processor count (jellyfin#11569) * Change "try" to "attempt" english translation (jellyfin#11578) * Bump version to 10.9.1 --------- Co-authored-by: Cody Robibero <cody@robibe.ro> Co-authored-by: gnattu <gnattu@users.noreply.github.com> Co-authored-by: Tim Gels <43609220+TimGels@users.noreply.github.com> Co-authored-by: Jellyfin Release Bot <team@jellyfin.org>
joshuaboniface
pushed a commit
that referenced
this pull request
May 13, 2024
Change "try" to "attempt" english translation Original-merge: 25c50bc Merged-by: crobibero <cody@robibe.ro> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the US English translation of
FailedLoginAttemptWithUserName. Personally I have never heard or readtrybeing used in this way. I always have seenattemptbeing used in this context.Changes
This changes "Failed login try from {0}" to "Failed login attempt from {0}" which is a more usual way of writing such sentence.
Issues
N/ A