Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to processor count concurrent scan instead of 2 * processor count #11569

Merged
merged 2 commits into from May 12, 2024
Merged

Default to processor count concurrent scan instead of 2 * processor count #11569

merged 2 commits into from May 12, 2024

Conversation

crobibero
Copy link
Member

No description provided.

@crobibero crobibero added the stable backport Backport into the next stable release label May 12, 2024
@crobibero crobibero requested a review from a team May 12, 2024 15:48
@crobibero crobibero added this to In progress in Release 10.9.z via automation May 12, 2024
@thornbill
Copy link
Member

We will also need to update the placeholder value in the web settings.

@cvium
Copy link
Member

cvium commented May 12, 2024

This isn't a 10.9 feature iirc. Isn't defaulting to 1 a step backwards?

@crobibero
Copy link
Member Author

This isn't a 10.9 feature iirc. Isn't defaulting to 1 a step backwards?

Before 10.9 it was defaulted to just ProcessorCount (3982b0e#diff-41e6711494c9c6ceb7d6aab39d16245177564b0711e402cb2c757d37c3b6815eL589)

We can change the default back to that if desired

@Bond-009
Copy link
Member

This isn't a 10.9 feature iirc. Isn't defaulting to 1 a step backwards?

Before 10.9 it was defaulted to just ProcessorCount (3982b0e#diff-41e6711494c9c6ceb7d6aab39d16245177564b0711e402cb2c757d37c3b6815eL589)

We can change the default back to that if desired

Yes I think that's the correct solution here.
I changed it as it worked fine for me, but I only have 6 cores in my server and no SMT.

@crobibero crobibero changed the title Default to 1 concurrent scan instead of 2 * processor count Default to processor count concurrent scan instead of 2 * processor count May 12, 2024
@nielsvanvelzen nielsvanvelzen added bug Something isn't working enhancement Improving an existing function, or small fixes and removed bug Something isn't working labels May 12, 2024
@crobibero crobibero merged commit f77a5d0 into jellyfin:release-10.9.z May 12, 2024
15 of 18 checks passed
Release 10.9.z automation moved this from In progress to Done May 12, 2024
scampower3 added a commit to scampower3/jellyfin that referenced this pull request May 13, 2024
@scampower3 @crobibero
@gnattu @TimGels @jellyfin-bot
Release 10.9.1 (#6)
6716739 
* Fix migration with special Rating (jellyfin#11541)

* Add metrics collector to disposable parts (jellyfin#11539)

* Fix absolute path checking on windows (jellyfin#11570)

* Default to processor count concurrent scan instead of 2 * processor count (jellyfin#11569)

* Change "try" to "attempt" english translation (jellyfin#11578)

* Bump version to 10.9.1

---------

Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: gnattu <gnattu@users.noreply.github.com>
Co-authored-by: Tim Gels <43609220+TimGels@users.noreply.github.com>
Co-authored-by: Jellyfin Release Bot <team@jellyfin.org>
joshuaboniface pushed a commit that referenced this pull request May 13, 2024
@crobibero @joshuaboniface
Backport pull request #11569 from jellyfin/release-10.9.z
3564b00 
Default to processor count concurrent scan instead of 2 * processor count

Original-merge: f77a5d0

Merged-by: crobibero <cody@robibe.ro>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill left review comments

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@Shadowghost Shadowghost Shadowghost approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

Assignees
No one assigned
Labels
enhancement Improving an existing function, or small fixes
Projects
Release 10.9.z
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@crobibero @thornbill @cvium @Bond-009 @nielsvanvelzen @Shadowghost @jellyfin-bot