Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sorting by premier dates to the /Items/Latest api endpoint #11512

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

scampower3
Copy link
Member

@scampower3 scampower3 commented May 8, 2024

Changes

Adds sorting by premier dates to the /Items/Latest api endpoint
Also adds NewReleases enum to HomeSectionType and SortBy to LatestItemsQuery
For: jellyfin/jellyfin-web#5464
Supersedes: #10443
Issues

Copy link

github-actions bot commented May 8, 2024

Changes in OpenAPI specification found. Expand to see details.

What's Changed


GET /Items/Latest
Parameters:

Added: sortByDateAdded in query

Whether or not to sort by date added or by premier date.

@scampower3 scampower3 marked this pull request as draft May 8, 2024 12:59
@scampower3 scampower3 marked this pull request as ready for review May 8, 2024 13:02
@thornbill
Copy link
Member

I'm curious if we really need to use the Latest API vs just using the Items API... I believe the only real difference is how it handles episodes (returning individual episodes if only one is new and the show if more than one is new) and I'm not sure that is functionality we want to continue using. 🤷‍♂️

@scampower3
Copy link
Member Author

Tbh, I rather keep that functionality. IMO, it looks kinda bad when a show has a multiple episodes premiering on the same day and the homepage displays each episode contiguously. To me, it looks better when the episodes are grouped together

@thornbill
Copy link
Member

Right. I was proposing always showing the season even when there is a single new episode... but I was probably too brief. 🙂

@scampower3
Copy link
Member Author

Personally, I prefer showing single episode when there is only one new episode.

@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label May 15, 2024
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants