Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Telemetry Exporter #11386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lackolaxton
Copy link

Add OTEL exporter options. For anyone that self hosts and has a collector, it would be useful for thme to get the metrics and tracing to help monitor performance.

@lackolaxton lackolaxton changed the title add otel Add Open Telemetry Exporter Apr 18, 2024
Copy link

Changes in OpenAPI specification found. Expand to see details.

What's Changed


GET /System/Configuration
Return Type:

Changed response : 200 OK

Application configuration returned.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Added property OtelConfiguration (object)

Gets or sets the otel config.

One of:

openapi-base openapi-changes.md openapi-head Property Enabled (boolean)

Gets or Sets a value indicating whether to enable otlp.

openapi-base openapi-changes.md openapi-head Property Endpoint (string)

Gets or Sets the endpoint to exporter to.

openapi-base openapi-changes.md openapi-head Property Meters (string)

Gets or sets the meters to listen to.

openapi-base openapi-changes.md openapi-head Property ActivitySources (string)

Gets or sets the activity sources to listen to.

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Added property OtelConfiguration (object)

Gets or sets the otel config.

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Added property OtelConfiguration (object)

Gets or sets the otel config.

POST /System/Configuration
Request:

Changed content type : application/json

Updated ServerConfiguration :

  • Added property OtelConfiguration (object)

Gets or sets the otel config.

Changed content type : text/json

Updated ServerConfiguration :

  • Added property OtelConfiguration (object)

Gets or sets the otel config.

Changed content type : application/*+json

Updated ServerConfiguration :

  • Added property OtelConfiguration (object)

Gets or sets the otel config.

@rasmustwh
Copy link

rasmustwh commented Apr 19, 2024

Wouldn't auto-instrumentation be more useful and flexible for everyone? The hardcoded instrumentation seems rather overkill for most use cases.

@lackolaxton
Copy link
Author

Wouldn't auto-instrumentation be more useful and flexible for everyone? The hardcoded instrumentation seems rather overkill for most use cases.

Never really thought of auto instrumentation. If someone is hosting in containers though it'll make it hard to do, so having this option at least gives the Hoster a way to get decent metrics etc.

I plan to try and add some tracing and better metrics so this is just a start

@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label May 15, 2024
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants