push/pull run cache by default #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10433 +/- ##
==========================================
- Coverage 90.61% 90.45% -0.17%
==========================================
Files 503 481 -22
Lines 39004 35916 -3088
Branches 5635 4145 -1490
==========================================
- Hits 35344 32487 -2857
+ Misses 2985 2849 -136
+ Partials 675 580 -95 ☔ View full report in Codecov by Sentry. |
|
@dberenbaum what is the context for this? (Discord? something else) |
shcheklein
approved these changes
May 20, 2024
|
The immediate context for this is in https://iterativeai.slack.com/archives/C03JS2V4MQU/p1715944944054679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should push/pull the run-cache by default. Technically, this should be in a major release, but I don't see how it will cause problems (the existing flags work the same, and the run cache will usually be relatively small relative to whatever else is pushed/pulled).